Skip to content

Add CI workflow to run cdb2jdbc tests against Docker comdb2 - #6120

Open
hgeraldino wants to merge 1 commit into
bloomberg:mainfrom
hgeraldino:ci/cdb2jdbc-integration-tests
Open

Add CI workflow to run cdb2jdbc tests against Docker comdb2#6120
hgeraldino wants to merge 1 commit into
bloomberg:mainfrom
hgeraldino:ci/cdb2jdbc-integration-tests

Conversation

@hgeraldino

Copy link
Copy Markdown
Contributor

To improve CI, this runs the Comdb2 JDBC driver test suite against a locally built Comdb2 Docker image

@hgeraldino
hgeraldino force-pushed the ci/cdb2jdbc-integration-tests branch 2 times, most recently from 902ecbe to 84637b1 Compare August 7, 2026 19:59
Signed-off-by: Hector Geraldino <hgeraldino@bloomberg.net>
@hgeraldino
hgeraldino force-pushed the ci/cdb2jdbc-integration-tests branch from 84637b1 to 1747ee7 Compare August 7, 2026 20:11
@SChakravorti21

Copy link
Copy Markdown
Contributor

@rishitha957 caught that the ClientInfoIT test is not run, we're not sure why.

Comment thread cdb2jdbc/pom.xml
<!-- SSLTest/SSLPreferTest need an SSL-enabled comdb2 server plus
client certificates, which the plain container used by CI
(.github/workflows/cdb2jdbc.yml) cannot provide. -->
<excludes>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be made command line arguments? The SSL features are tested here.

-Dmaven.javadoc.skip=true \
-Dcdb2jdbc.test.cluster=comdb2 \
-Dcdb2jdbc.test.database="$DBNAME" \
test

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn test won't run integration tests. We can use mvn verify or simply mvn install.

@riverszhang89

Copy link
Copy Markdown
Contributor

@rishitha957 caught that the ClientInfoIT test is not run, we're not sure why.

ClientInfoIT is an "integration" test; mvn test only runs "unit" tests (Technically most cdb2jdbc testcases are integration tests...) I think we can drop ClientInfoIT. There's already a ClientInfoTest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants